On Mon, 14 Jun 2021 16:47:52 -0700
Andrew Morton [off-list ref] wrote:

Should/can afs_SRXCB##name##_name[] be static?

Probably.
	

__tracepoint_string is very rarely used.  I wonder if there's much
point in it existing?

There's a few places that the "tracepoint_string()" couldn't be used,
and this was a workaround for those locations. Yes, it's not used much,
but what's the other solution should we use to replace it?

kernel/rcu/tree.h does

static char rcu_name[] = RCU_NAME_RAW;
static const char *tp_rcu_varname __used __tracepoint_string = rcu_name;

which is asking the compiler to place a copy of these into each
compilation unit which includes tree.h, which probably isn't what was
intended.

Yeah, there's a couple of duplicates. Perhaps we can move them into a C
file, and have it simply exported.

-- Steve