sw_i2c_ack() contains only a return statement, so calling it has
no effect. Remove the empty helper and the ack parameter from
sw_i2c_read_byte(), along with the parameter documentation.
Update the only caller to use the parameterless helper. The GPIO
operations and existing I2C bus behavior remain unchanged.
Signed-off-by: Ali Köse <redacted>
---
drivers/staging/sm750fb/ddk750_swi2c.c | 19 ++-----------------
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c
index e63f3b00ec4c..54ce355e535f 100644
--- a/drivers/staging/sm750fb/ddk750_swi2c.c
+++ b/drivers/staging/sm750fb/ddk750_swi2c.c
@@ -201,14 +201,6 @@ static unsigned char sw_i2c_read_sda(void)
return 0;
}
-/*
- * This function sends ACK signal
- */
-static void sw_i2c_ack(void)
-{
- return; /* Single byte read is ok without it. */
-}
-
/*
* This function sends the start command to the slave device
*/@@ -300,14 +292,10 @@ static long sw_i2c_write_byte(unsigned char data)
/*
* This function reads one byte from the slave device
*
- * Parameters:
- * ack - Flag to indicate either to send the acknowledge
- * message to the slave device or not
- *
* Return Value:
* One byte data read from the Slave device
*/
-static unsigned char sw_i2c_read_byte(unsigned char ack)
+static unsigned char sw_i2c_read_byte(void)
{
int i;
unsigned char data = 0;@@ -326,9 +314,6 @@ static unsigned char sw_i2c_read_byte(unsigned char ack)
data |= (sw_i2c_read_sda() << i);
}
- if (ack)
- sw_i2c_ack();
-
/* Set the SCL Low and SDA High */
sw_i2c_scl(0);
sw_i2c_sda(1);
@@ -458,7 +443,7 @@ unsigned char sm750_sw_i2c_read_reg(unsigned char addr, unsigned char reg)
/* Get the bus again and get the data from the device read address */
sw_i2c_start();
sw_i2c_write_byte(addr + 1);
- data = sw_i2c_read_byte(1);
+ data = sw_i2c_read_byte();
/* Stop swI2C and release the bus */
sw_i2c_stop();
--
2.53.0