Replace the set_DAC macro with a static function named set_dac().
The helper has only one caller, so keep it local to ddk750_display.c
and remove the macro from ddk750_power.h.
This provides parameter type checking and follows kernel naming
conventions without changing the register operation.
Signed-off-by: Ali Köse <redacted>
---
drivers/staging/sm750fb/ddk750_display.c | 8 +++++++-
drivers/staging/sm750fb/ddk750_power.h | 5 -----
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
index 4e390541a507..d619e00fd88e 100644
--- a/drivers/staging/sm750fb/ddk750_display.c
+++ b/drivers/staging/sm750fb/ddk750_display.c
@@ -4,6 +4,12 @@
#include "ddk750_display.h"
#include "ddk750_power.h"
+static void set_dac(unsigned int off)
+{
+ poke32(MISC_CTRL,
+ (peek32(MISC_CTRL) & ~MISC_CTRL_DAC_POWER_OFF) | off);
+}
+
static void set_display_control(int ctrl, int disp_state)
{
/* state != 0 means turn on both timing & plane en_bit */@@ -151,7 +157,7 @@ void ddk750_set_logical_disp_out(enum disp_output output)
}
if (output & DAC_USAGE)
- set_DAC((output & DAC_MASK) >> DAC_OFFSET);
+ set_dac((output & DAC_MASK) >> DAC_OFFSET);
if (output & DPMS_USAGE)
ddk750_set_dpms((output & DPMS_MASK) >> DPMS_OFFSET);
diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h
index 0c4ab2120385..61f8608e59de 100644
--- a/drivers/staging/sm750fb/ddk750_power.h
+++ b/drivers/staging/sm750fb/ddk750_power.h
@@ -9,11 +9,6 @@ enum dpms {
CRT_DPMS_OFF = 0x3,
};
-#define set_DAC(off) { \
- poke32(MISC_CTRL, \
- (peek32(MISC_CTRL) & ~MISC_CTRL_DAC_POWER_OFF) | (off)); \
-}
-
void ddk750_set_dpms(enum dpms state);
void sm750_set_power_mode(unsigned int mode);
void sm750_set_current_gate(unsigned int gate);--
2.53.0