Re: [PATCH 1/5] vt: Add cursor-size helpers

Hi

Am 12.09.26 um 21:01 schrieb Helge Deller:

On 9/11/26 11:25, Thomas Zimmermann wrote:

quoted

Cursors in the VT subsystem are blocks within a character cell that are
filled with the foreground color. The new helpers vc_font_cursor_start()
and vc_font_cursor_end() return the scanlines in which the cursor block
starts rsp. ends. This is compatible with VGA hardware

In terms of cursor design, the new cursor-size helpers follow 
established
styles in fbcon. The only exception is in underline cursors for fonts 
with
a size larger than 10. The underlining dash is now one pixel closer to
the font-glyph data, so that the cursor looks less detached. This 
follows
the style used by vgacon.

Similar code in vgacon and fbcon ignores the cursor's default size 
stored
in vt.cur_default. The consoles default to full-block cursors, while vt
defaults to underline cursors. The new helper fall back to 
cur_default and
then underline cursors; in this order.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
  drivers/tty/vt/vt.c            | 90 ++++++++++++++++++++++++++++++++++
  include/linux/console_struct.h |  2 +
  2 files changed, 92 insertions(+)

You may add
Reviewed-by: Helge Deller <deller@gmx.de>
to the whole series.

Thanks a lot. I'll send out another revision to address the bot's concerns.

Best regards
Thomas

Thanks!
Helge

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)