Re: [Patch 9/9]: vt: Misc changes, e.g. to #include directives
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2026-08-29 12:08:09
Also in:
dri-devel, linux-serial, lkml
On Thu, Aug 27, 2026 at 06:58:48PM +0000, Alan Mackenzie wrote:
vt: 32b glyph: 9. Misc changes, e.g. to #include directives Rearrange some #include directives, add some clarifying comments, and some code changes which didn't fit elsewhere.
But you need to list those code changes and why you are making them, and the #include stuff should be it's own patch, right? And why this:
quoted hunk ↗ jump to hunk
diff --git a/drivers/tty/vt/selection.c b/drivers/tty/vt/selection.c index 13f4e48b4142..18affdb3c7c5 100644 --- a/drivers/tty/vt/selection.c +++ b/drivers/tty/vt/selection.c@@ -48,6 +48,8 @@ static struct vc_selection { .start = -1, }; +static unsigned int size_row; + /* clear_selection, highlight and highlight_pointer can be called from interrupt (via scrollback/front) */@@ -340,6 +342,7 @@ static int vc_selection(struct vc_data *vc, struct tiocl_selection *v, { int ps, pe; + size_row = vc->vc_size_row; poke_blanked_console(); if (v->sel_mode == TIOCL_SELCLEAR) {
You set a local variable that is never actually used anywhere? This feels very very odd, especially as the "last" patch in the series. greg k-h