Thread (23 messages) flat view 23 messages, 5 authors, 3d ago

Re: [Patch 1/9]: Make consolemap.c handle Unicode planes outside BMP

From: Jiri Slaby <jirislaby@kernel.org>
Date: 2026-08-28 04:57:11
Also in: dri-devel, linux-serial, lkml

On 27. 08. 26, 20:42, Alan Mackenzie wrote:
quoted hunk ↗ jump to hunk
vt: 32b glyph: 1. Make consolemap.c handle Unicode planes outside BMP

For this, add a fourth layer "planes" onto the sparse map in
this file.  Also handle glyph numbers up to 2^21 rather than
256/512.  Move the conversion between __user and kernel data
from consolemap.c to vt_ioctl.c.

Signed-off-by: Alan Mackenzie <redacted>
diff --git a/drivers/tty/vt/consolemap.c b/drivers/tty/vt/consolemap.c
index 3fa89a2dbeba..2f695d97f0eb 100644
--- a/drivers/tty/vt/consolemap.c
+++ b/drivers/tty/vt/consolemap.c
@@ -34,11 +34,11 @@
  #include <linux/tty.h>
  #include <linux/uaccess.h>
  #include <linux/console.h>
-#include <linux/consolemap.h>
  #include <linux/vt_kern.h>
+#include <linux/consolemap.h>
Why do you do this?
  #include <linux/string.h>
  
-static unsigned short translations[][E_TABSZ] = {
+static u1632 translations[][E_TABSZ] = {
This breaks the build at this point, right?

u1632 is a bad name though.

 > For the avoidance of doubt, no LLM has been used in the preparation 
of this change.

Given the above, perhaps you should have?

See also what Sashiko thinks:
https://sashiko.dev/#/patchset/apCEDM2sWv_M354-%40MAC.fritz.box

thanks,
-- 
js
suse labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help