Thread (13 messages) 13 messages, 4 authors, 22h ago

Re: [PATCH v2 3/8] Add Advantech EIO Hardware Monitor driver

From: Guenter Roeck <linux@roeck-us.net>
Date: 2026-07-16 00:29:06
Also in: dri-devel, linux-gpio, linux-hwmon, linux-i2c, linux-pm, linux-watchdog, lkml

On 7/14/26 08:54, Ramiro Oliveira wrote:
This driver controls the Hardware Monitor block of the Advantech EIO chip.

There is a separate driver for the thermal device driver
since it's a use case we support currently, but if it's
really necessary we can move it to the same driver.

Signed-off-by: Ramiro Oliveira <redacted>
Normally there would be a hwmon driver instantiating the thermal zone(s)
using HWMON_C_REGISTER_TZ. If the driver actively controls thermal zones
since it also handles fans, that would be instantiated from the hwmon driver.

Since you have both thermal temperature and thermal fan drivers, I am very
concerned that there is functionality overlap andor even conflicts. You
should drop this driver and configure the thermal temperature driver
to instantiate a hwmon device from it if so desired.

Thanks,
Guenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help