Re: [PATCH 13/13] mm/mremap: convert mremap code to use vma_flags_t

[PATCH 00/13] convert more vm_flags_t users to vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-06-29
[PATCH 01/13] mm: introduce vma_flags_can_grow() and vma_can_grow() · Lorenzo Stoakes <ljs@kernel.org> · 2026-06-29
Re: [PATCH 01/13] mm: introduce vma_flags_can_grow() and vma_can_grow() · "Zi Yan" <ziy@nvidia.com> · 2026-06-29
Re: [PATCH 01/13] mm: introduce vma_flags_can_grow() and vma_can_grow() · Lorenzo Stoakes <ljs@kernel.org> · 2026-06-30
Re: [PATCH 01/13] mm: introduce vma_flags_can_grow() and vma_can_grow() · "Zi Yan" <ziy@nvidia.com> · 2026-06-30
Re: [PATCH 01/13] mm: introduce vma_flags_can_grow() and vma_can_grow() · Lance Yang <lance.yang@linux.dev> · 2026-07-02
Re: [PATCH 01/13] mm: introduce vma_flags_can_grow() and vma_can_grow() · "Zi Yan" <ziy@nvidia.com> · 2026-07-03
[PATCH 02/13] mm/vma: update do_mmap() to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-06-29
Re: [PATCH 02/13] mm/vma: update do_mmap() to use vma_flags_t · Lance Yang <lance.yang@linux.dev> · 2026-07-02
Re: [PATCH 02/13] mm/vma: update do_mmap() to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-07-02
Re: [PATCH 02/13] mm/vma: update do_mmap() to use vma_flags_t · Lance Yang <lance.yang@linux.dev> · 2026-07-02
Re: [PATCH 02/13] mm/vma: update do_mmap() to use vma_flags_t · "Zi Yan" <ziy@nvidia.com> · 2026-07-07
Re: [PATCH 02/13] mm/vma: update do_mmap() to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-07-07
[PATCH 03/13] mm: convert __get_unmapped_area() to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-06-29
Re: [PATCH 03/13] mm: convert __get_unmapped_area() to use vma_flags_t · Lance Yang <lance.yang@linux.dev> · 2026-07-02
Re: [PATCH 03/13] mm: convert __get_unmapped_area() to use vma_flags_t · "Zi Yan" <ziy@nvidia.com> · 2026-07-07
Re: [PATCH 03/13] mm: convert __get_unmapped_area() to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-07-07
[PATCH 07/13] mm/vma: rename vma_get_page_prot to vma_flags_to_page_prot · Lorenzo Stoakes <ljs@kernel.org> · 2026-06-29
Re: [PATCH 07/13] mm/vma: rename vma_get_page_prot to vma_flags_to_page_prot · Lance Yang <lance.yang@linux.dev> · 2026-07-02
Re: [PATCH 07/13] mm/vma: rename vma_get_page_prot to vma_flags_to_page_prot · "Zi Yan" <ziy@nvidia.com> · 2026-07-08
[PATCH 04/13] mm: update generic_get_unmapped_area[_topdown]() to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-06-29
Re: [PATCH 04/13] mm: update generic_get_unmapped_area[_topdown]() to use vma_flags_t · Lance Yang <lance.yang@linux.dev> · 2026-07-02
Re: [PATCH 04/13] mm: update generic_get_unmapped_area[_topdown]() to use vma_flags_t · "Zi Yan" <ziy@nvidia.com> · 2026-07-07
[PATCH 05/13] mm: prefer mm->def_vma_flags in mm logic · Lorenzo Stoakes <ljs@kernel.org> · 2026-06-29
Re: [PATCH 05/13] mm: prefer mm->def_vma_flags in mm logic · Lance Yang <lance.yang@linux.dev> · 2026-07-02
Re: [PATCH 05/13] mm: prefer mm->def_vma_flags in mm logic · Lorenzo Stoakes <ljs@kernel.org> · 2026-07-02
Re: [PATCH 05/13] mm: prefer mm->def_vma_flags in mm logic · "Zi Yan" <ziy@nvidia.com> · 2026-07-08
[PATCH 06/13] mm/vma: convert vm_pgprot_modify() to use vma_flags_t and rename · Lorenzo Stoakes <ljs@kernel.org> · 2026-06-29
Re: [PATCH 06/13] mm/vma: convert vm_pgprot_modify() to use vma_flags_t and rename · Lance Yang <lance.yang@linux.dev> · 2026-07-02
Re: [PATCH 06/13] mm/vma: convert vm_pgprot_modify() to use vma_flags_t and rename · Lorenzo Stoakes <ljs@kernel.org> · 2026-07-02
Re: [PATCH 06/13] mm/vma: convert vm_pgprot_modify() to use vma_flags_t and rename · "Zi Yan" <ziy@nvidia.com> · 2026-07-08
[PATCH 08/13] mm: introduce vma_get_page_prot() and use it · Lorenzo Stoakes <ljs@kernel.org> · 2026-06-29
Re: [PATCH 08/13] mm: introduce vma_get_page_prot() and use it · Thomas Zimmermann <tzimmermann@suse.de> · 2026-06-30
Re: [PATCH 08/13] mm: introduce vma_get_page_prot() and use it · Jani Nikula <jani.nikula@linux.intel.com> · 2026-06-30
Re: [PATCH 08/13] mm: introduce vma_get_page_prot() and use it · Lance Yang <lance.yang@linux.dev> · 2026-07-02
Re: [PATCH 08/13] mm: introduce vma_get_page_prot() and use it · Lorenzo Stoakes <ljs@kernel.org> · 2026-07-02
Re: [PATCH 08/13] mm: introduce vma_get_page_prot() and use it · "Zi Yan" <ziy@nvidia.com> · 2026-07-08
[PATCH 10/13] mm/vma: convert miscellaneous uses of VMA flags in core mm · Lorenzo Stoakes <ljs@kernel.org> · 2026-06-29
Re: [PATCH 10/13] mm/vma: convert miscellaneous uses of VMA flags in core mm · Lance Yang <lance.yang@linux.dev> · 2026-07-02
Re: [PATCH 10/13] mm/vma: convert miscellaneous uses of VMA flags in core mm · Lorenzo Stoakes <ljs@kernel.org> · 2026-07-02
Re: [PATCH 10/13] mm/vma: convert miscellaneous uses of VMA flags in core mm · "Zi Yan" <ziy@nvidia.com> · 2026-07-09
Re: [PATCH 10/13] mm/vma: convert miscellaneous uses of VMA flags in core mm · Lorenzo Stoakes <ljs@kernel.org> · 2026-07-11
Re: [PATCH 10/13] mm/vma: convert miscellaneous uses of VMA flags in core mm · Lorenzo Stoakes <ljs@kernel.org> · 2026-07-11
[PATCH 09/13] mm/vma: update create_init_stack_vma() to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-06-29
Re: [PATCH 09/13] mm/vma: update create_init_stack_vma() to use vma_flags_t · Lance Yang <lance.yang@linux.dev> · 2026-07-02
Re: [PATCH 09/13] mm/vma: update create_init_stack_vma() to use vma_flags_t · "Zi Yan" <ziy@nvidia.com> · 2026-07-09
[PATCH 11/13] mm/mlock: convert mlock code to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-06-29
Re: [PATCH 11/13] mm/mlock: convert mlock code to use vma_flags_t · Lance Yang <lance.yang@linux.dev> · 2026-07-02
Re: [PATCH 11/13] mm/mlock: convert mlock code to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-07-02
Re: [PATCH 11/13] mm/mlock: convert mlock code to use vma_flags_t · "Zi Yan" <ziy@nvidia.com> · 2026-07-09
Re: [PATCH 11/13] mm/mlock: convert mlock code to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-07-11
[PATCH 12/13] mm/mprotect: convert mprotect code to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-06-29
Re: [PATCH 12/13] mm/mprotect: convert mprotect code to use vma_flags_t · Lance Yang <lance.yang@linux.dev> · 2026-07-01
Re: [PATCH 12/13] mm/mprotect: convert mprotect code to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-07-02
Re: [PATCH 12/13] mm/mprotect: convert mprotect code to use vma_flags_t · "Zi Yan" <ziy@nvidia.com> · 2026-07-09
Re: [PATCH 12/13] mm/mprotect: convert mprotect code to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-07-11
[PATCH 13/13] mm/mremap: convert mremap code to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-06-29
Re: [PATCH 13/13] mm/mremap: convert mremap code to use vma_flags_t · Lance Yang <lance.yang@linux.dev> · 2026-07-02
Re: [PATCH 13/13] mm/mremap: convert mremap code to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-07-02
Re: [PATCH 13/13] mm/mremap: convert mremap code to use vma_flags_t · Lance Yang <lance.yang@linux.dev> · 2026-07-02
Re: [PATCH 13/13] mm/mremap: convert mremap code to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-07-02
Re: [PATCH 13/13] mm/mremap: convert mremap code to use vma_flags_t · "Zi Yan" <ziy@nvidia.com> · 2026-07-09
Re: [PATCH 13/13] mm/mremap: convert mremap code to use vma_flags_t · Lorenzo Stoakes <ljs@kernel.org> · 2026-07-11

From: Lorenzo Stoakes <ljs@kernel.org>
Date: 2026-07-11 17:10:06
Also in: dri-devel, intel-gfx, intel-xe, linux-arm-msm, linux-fsdevel, linux-mips, linux-mm, linux-samsung-soc, linux-sound, linux-tegra, linuxppc-dev, lkml, nouveau, virtualization, xen-devel

On Wed, Jul 08, 2026 at 10:28:00PM -0400, Zi Yan wrote:

On Thu Jul 2, 2026 at 12:07 PM EDT, Lorenzo Stoakes wrote:

quoted

On Thu, Jul 02, 2026 at 09:49:47PM +0800, Lance Yang wrote:

quoted

On Mon, Jun 29, 2026 at 08:25:36PM +0100, Lorenzo Stoakes wrote:

quoted

Replace use of the legacy vm_flags_t flags with vma_flags_t values
throughout the mremap logic.

Additionally update comments to reflect the changes to be consistent.

No functional change intended.

Signed-off-by: Lorenzo Stoakes <ljs@kernel.org>
---

The vm_flags_set() cases below spell out vma_start_write(), but the
vm_flags_clear() cases don't?

Yep as I said elsewhere, implicitly taking the lock is terrible and me doing
this is completely on purpose to get rid of that :)

But I haven't been clear enough clearly, so I should put the argument as to why
that's ok in the commit message.

Will do so on respin.

How about also add a comment to vma_clear*() telling us a lock is not
needed and why like you explained a lock is needed for vma_set*()?
This asymmetry could confuse people.

Well you do absolutely have to hold the lock once the VMA is initialised when
using any VMA flags API that manipulates flags (apart from the explicitly atomic
case).

The argument here is that the VMA was _already locked_ at the point of clearing
:)

This patch looks good to me.

Reviewed-by: Zi Yan <ziy@nvidia.com>

Thanks!

--
Best Regards,
Yan, Zi

Cheers, Lorenzo

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help