Thread (10 messages) 10 messages, 2 authors, 1h ago

Re: [PATCH v4] staging: sm750fb: rename variables to comply with kernel style

From: Andre Moreira <hidden>
Date: 2026-07-07 13:28:24
Also in: linux-staging, lkml

Please disregard this v4 patch.

Upon closer inspection, the 'init_status' struct has been completely
removed from the driver by a previous upstream commit, making this
cleanup obsolete. Sorry for the noise.


Em ter., 7 de jul. de 2026 às 10:17, André Moreira
[off-list ref] escreveu:
quoted hunk ↗ jump to hunk
Rename 'setAllEngOff' to 'set_all_eng_off' within the 'init_status'
struct to avoid CamelCase and comply with the Linux kernel coding style.

Signed-off-by: André Moreira <redacted>
---
v4:
  - Drop register renames 'pvReg' to 'regs' as they were merged via another upstream patch.
  - Keep only the 'init_status' CamelCase cleanup.

drivers/staging/sm750fb/sm750.h | 9 +++++++++
 1 file changed, 9 insertions(+)
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index 0324778768cbc..3a1bd38ab347a 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -39,6 +39,15 @@ enum sm750_path {
        sm750_pnc = 3,  /* panel and crt */
 };

+struct init_status {
+       ushort power_mode;
+       /* below three clocks are in unit of MHZ*/
+       ushort chip_clk;
+       ushort mem_clk;
+       ushort master_clk;
+       ushort set_all_eng_off;
+       ushort reset_memory;
+};

 struct lynx_accel {
        /* base virtual address of DPR registers */
--
2.43.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help