Re: [PATCH] staging: vme_user: vme_bridge.h: Fix mutex without comment warning

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Wed, Jul 31, 2024 at 01:34:56PM +0530, Riyan Dhiman wrote:

Hello,

Thank you for reviewing my patch. I received your feedback:

quoted

Are you sure about all of these?  Please document them individually and
put the proof of that in the changelog text.

I'd like to clarify a few points to ensure I address your concerns
correctly:

1. By "document them individually", do you mean I should submit
separate patches for each mutex documentation change?

Yes.

2. Regarding the "proof" for the changelog text, could you please elaborate
on what kind of proof you 're looking for? Should I include:
 - References to the code where these mutexes are used?
 - Explanations of the race conditions these mutexes prevent?
 - Citations from the driver's design documentation (if available)?

Whatever you feel would be needed to convince everyone that the comment
is now correct.

3. Is there a preferred format or level of detail you'd like to see in the
changelog for each documentation change?

What would you want to see if you had to review this type of change to
be comfortable accepting it?

thanks,

greg k-h