Thread (6 messages) 6 messages, 1 author, 2d ago

[PATCH 0/5] fbdev: Remove use of VESA constants

flat view
WARM2d

From: Thomas Zimmermann <tzimmermann@suse.de>
Date: 2026-10-09 16:18:30
Also in: linux-arm-kernel, lkml, sashiko-reviews

Fbdev and its drivers use FB_BLANK constants for controlling the display
blanking state in the fb_blank callback. Several drivers implement the
callback with VESA constants; thus mixing up semantics.

Update the drivers to use VESA constants instead.

Some background: the VESA constants describe DPMS levels for monitor
singal generation. VESA_NO_BLANKING means that the sync signals are on,
although the display adapter might not transfer meaningful pixel data.
The constants FB_BLANK_NORMAL represents this case in fbdev, while
FB_BLANK_UNBLANK represents enabled sync signal generation plus pixel
data. Fbdev drivers using VESA constants therefore often contain
off-by-one errors.

Thomas Zimmermann (5):
  fbdev/au1100fb: Use FB blanking constants
  fbdev/i810fb: Use FB blanking constants
  fbdev/sa1100fb: Remove comment on VESA DPMS modes
  fbdev/platinumfb: Use FB blanking constants
  fbdev/xilinxfb: Use FB blanking constants

 drivers/video/fbdev/au1100fb.c       | 18 ++++++++---------
 drivers/video/fbdev/i810/i810_main.c |  2 +-
 drivers/video/fbdev/platinumfb.c     |  8 +++++---
 drivers/video/fbdev/sa1100fb.c       | 29 ----------------------------
 drivers/video/fbdev/xilinxfb.c       |  2 +-
 5 files changed, 16 insertions(+), 43 deletions(-)

-- 
2.55.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help