On Thu, Mar 14, 2024 at 09:16:15AM +0100, Thomas Zimmermann wrote:

Hi

Am 13.03.24 um 19:00 schrieb Sam Ravnborg:

quoted

Hi Thomas,

On Wed, Mar 13, 2024 at 04:45:02PM +0100, Thomas Zimmermann wrote:

quoted

The backlight is on for fb_blank eq FB_BLANK_UNBLANK, or off for
any other value in fb_blank. But the field fb_blank in struct
backlight_properties is deprecated and should not be used any
longer.

Replace the test for fb_blank in omap's backlight code with a
simple boolean parameter and push the test into the update_status
helper. Instead of reading fb_blank directly, decode the backlight
device's status with backlight_is_blank().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>

My biased opinion is that the approach in this patch is a little bit
better:
https://lore.kernel.org/lkml/20230107-sam-video-backlight-drop-fb_blank-v1-13-1bd9bafb351f@ravnborg.org/ (local)

I never came around resending this series it seems.

Oh, that series has been around for over a year. I don't care about which
patches go in as long as they remove the dependency on <linux/fb.h>. I saw
that Dan has already r-b'ed the current patchset, but if you prefer I'll
adopt yours.

Whatever works for you. It is trivial stuff and as long as we get it
cleaned up that is fine. You are pushing for this now - so whatever is
easiest for you.

	Sam