Re: [PATCH 1/6] auxdisplay/ht16k33: Replace use of fb_blank with backlight helper
From: Miguel Ojeda <hidden>
Date: 2024-03-13 16:08:22
Also in:
dri-devel, linux-staging
From: Miguel Ojeda <hidden>
Date: 2024-03-13 16:08:22
Also in:
dri-devel, linux-staging
Hi Thomas, Thanks for this! Cc'ing Andy and Geert -- the new maintainer and reviewer. Also, a couple quick notes below since I am here... On Wed, Mar 13, 2024 at 4:49 PM Thomas Zimmermann [off-list ref] wrote:
Replace the use of struct backlight_properties.fb_blank with a call to backlight_get_brightness(). The helper implement the same logic as the driver's function.
It is not exactly the same logic since `backlight_is_blank` accounts for `BL_CORE_SUSPENDED`.
- int brightness = bl->props.brightness; + int brightness = backlight_get_brightness(bl);
This can be `const` now (or even removed and have the call embedded below). Cheers, Miguel