Hi

Am 02.02.24 um 18:54 schrieb Sui Jingfeng:

Hi,


On 2024/2/2 19:58, Thomas Zimmermann wrote:

quoted

+static inline void __screen_info_set_lfb_base(struct screen_info *si, 
u64 lfb_base)
+{
+    si->lfb_base = lfb_base & GENMASK_ULL(31, 0);
+    si->ext_lfb_base = (lfb_base & GENMASK_ULL(63, 32)) >> 32;
+
+    if (si->ext_lfb_base)
+        si->capabilities |= VIDEO_CAPABILITY_64BIT_BASE;
+    else
+        si->capabilities &= ~VIDEO_CAPABILITY_64BIT_BASE;
+}
+

Do we really has a need to modify the si->capabilities at here?

We need to set or clear the flag depending on the value of ext_lfb_base. 
Without the flag, decoders will ignore the value in ext_lfb_base.

Best regards
Thomas

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)