Re: [v2,7/8] firmware/sysfb: Update screen_info for relocated EFI framebuffers
From: Sui Jingfeng <hidden>
Date: 2024-02-02 17:55:05
Also in:
dri-devel
From: Sui Jingfeng <hidden>
Date: 2024-02-02 17:55:05
Also in:
dri-devel
Hi, On 2024/2/2 19:58, Thomas Zimmermann wrote:
+static inline void __screen_info_set_lfb_base(struct screen_info *si, u64 lfb_base)
+{
+ si->lfb_base = lfb_base & GENMASK_ULL(31, 0);
+ si->ext_lfb_base = (lfb_base & GENMASK_ULL(63, 32)) >> 32;
+
+ if (si->ext_lfb_base)
+ si->capabilities |= VIDEO_CAPABILITY_64BIT_BASE;
+ else
+ si->capabilities &= ~VIDEO_CAPABILITY_64BIT_BASE;
+}
+Do we really has a need to modify the si->capabilities at here?