Thread (37 messages) 37 messages, 7 authors, 2024-02-21

Re: [PATCH 10/10] backlight: Add controls_device callback to struct backlight_ops

From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2024-02-20 09:35:58
Also in: dri-devel, linux-input, linux-pwm

Thomas Zimmermann [off-list ref] writes:
Replace check_fb with controls_device in struct backlight_ops. The
new callback interface takes a Linux device instead of a framebuffer.
Resolves one of the dependencies of backlight.h on fb.h.

The few drivers that had custom implementations of check_fb can easily
use the framebuffer's Linux device instead. Update them accordingly.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
Personally, I don't like the "control_device" callback name that much. I
think that check_device or probe_device would be a better one and easier
to understand what it does.

But not strong opinion on that,

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help