Re: [PATCH 02/10] auxdisplay/ht16k33: Remove struct backlight_ops.check_fb
From: Robin van der Gracht <robin@protonic.nl>
Date: 2024-02-13 13:18:33
Also in:
dri-devel, linux-input, linux-pwm
On Mon, 12 Feb 2024 17:16:35 +0100 Thomas Zimmermann [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The driver sets struct fb_info.bl_dev to the correct backlight device. Thus rely on the backlight core code to match backlight and framebuffer devices, and remove the extra check_fb function from struct backlight_ops. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Cc: Robin van der Gracht <robin@protonic.nl> --- drivers/auxdisplay/ht16k33.c | 8 -------- 1 file changed, 8 deletions(-)diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c index a90430b7d07ba..0a858db32486b 100644 --- a/drivers/auxdisplay/ht16k33.c +++ b/drivers/auxdisplay/ht16k33.c@@ -325,16 +325,8 @@ static int ht16k33_bl_update_status(struct backlight_device *bl) return ht16k33_brightness_set(priv, brightness); } -static int ht16k33_bl_check_fb(struct backlight_device *bl, struct fb_info *fi) -{ - struct ht16k33_priv *priv = bl_get_data(bl); - - return (fi == NULL) || (fi->par == priv); -} - static const struct backlight_ops ht16k33_bl_ops = { .update_status = ht16k33_bl_update_status, - .check_fb = ht16k33_bl_check_fb, };
When combined with the previous patch: [01/10] backlight: Match backlight device against struct fb_info.bl_dev (I wasn't in the CC) Acked-By: Robin van der Gracht <robin@protonic.nl>