Re: [PATCH 3/4] media: platform: replace of_graph_get_next_endpoint()
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2024-02-07 13:57:37
Also in:
dri-devel, linux-arm-kernel, linux-media, linux-omap, linux-samsung-soc
On Tue, Feb 06, 2024 at 11:45:58PM +0000, Kuninori Morimoto wrote:
Hi Laurent Thank you for your reviewquoted
quoted
diff --git a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c b/drivers/media/platform/samsung/exynos4-is/mipi-csis.c index 686ca8753ba2..3f8bea2e3934 100644 --- a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c +++ b/drivers/media/platform/samsung/exynos4-is/mipi-csis.c@@ -728,7 +728,7 @@ static int s5pcsis_parse_dt(struct platform_device *pdev, &state->max_num_lanes)) return -EINVAL; - node = of_graph_get_next_endpoint(node, NULL); + node = of_graph_get_endpoint_by_regs(node, 0, -1);This is not correct, see Documentation/devicetree/bindings/media/samsung,exynos4210-csis.yaml.Hmm... Then, It can be like this ? + node = of_graph_get_endpoint_by_regs(node, -1, -1);
I suppose that would work, even if we should really try not to pass -1 for the port. Rob, any opinion ? -- Regards, Laurent Pinchart