Thread (14 messages) 14 messages, 3 authors, 2024-02-07

Re: [PATCH 3/4] media: platform: replace of_graph_get_next_endpoint()

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: 2024-02-06 23:46:01
Also in: dri-devel, linux-arm-kernel, linux-media, linux-omap, linux-samsung-soc

Hi Laurent

Thank you for your review
quoted
diff --git a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c b/drivers/media/platform/samsung/exynos4-is/mipi-csis.c
index 686ca8753ba2..3f8bea2e3934 100644
--- a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c
+++ b/drivers/media/platform/samsung/exynos4-is/mipi-csis.c
@@ -728,7 +728,7 @@ static int s5pcsis_parse_dt(struct platform_device *pdev,
 				 &state->max_num_lanes))
 		return -EINVAL;
 
-	node = of_graph_get_next_endpoint(node, NULL);
+	node = of_graph_get_endpoint_by_regs(node, 0, -1);
This is not correct, see
Documentation/devicetree/bindings/media/samsung,exynos4210-csis.yaml.
Hmm... Then, It can be like this ?

	+ node = of_graph_get_endpoint_by_regs(node, -1, -1);




Thank you for your help !!

Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help