Re: [PATCH 7/8] firmware/sysfb: Update screen_info for relocated EFI framebuffers
From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2024-01-29 11:52:40
Also in:
dri-devel
Thomas Zimmermann [off-list ref] writes:
On ARM PCI systems, the PCI hierarchy might be reconfigured during
boot and the firmware framebuffer might move as a result of that.
The values in screen_info will then be invalid.
Work around this problem by tracking the framebuffer's initial
location before it get relocated; then fix the screen_info state
between reloaction and creating the firmware framebuffer's device.
This functionality has been lifted from efifb. See the commit message
of commit 55d728a40d36 ("efi/fb: Avoid reconfiguration of BAR that
covers the framebuffer") for more information.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---[...]
#if defined(CONFIG_PCI)
Shouldn't this be && !defined(CONFIG_X86) ? Or maybe && defined(CONFIG_ARM64), although I don't know if the same also applies to other EFI platforms (e.g: CONFIG_RISCV). Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat