Re: [PATCH 19/45] tty: vt: make init parameter of consw::con_init() a bool
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2024-01-18 08:56:48
Also in:
dri-devel, linux-serial, lkml
Hi Jiri, On Thu, Jan 18, 2024 at 9:03 AM Jiri Slaby (SUSE) [off-list ref] wrote:
The 'init' parameter of consw::con_init() is true for the first call of the hook on a particular console. So make the parameter a bool. And document the hook. Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Thanks for your patch!
quoted hunk ↗ jump to hunk
--- a/drivers/video/console/vgacon.c +++ b/drivers/video/console/vgacon.c@@ -367,7 +367,7 @@ static const char *vgacon_startup(void) return display_desc; } -static void vgacon_init(struct vc_data *c, int init) +static void vgacon_init(struct vc_data *c, bool init) { struct uni_pagedict *p;
Below, there is one more line to update:
- /* set dimensions manually if init != 0 since vc_resize()
will fail */
+ /* set dimensions manually if init is true since
vc_resize() will fail */
With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds