On Thu, Jan 18, 2024 at 09:41:34AM +0100, Thomas Zimmermann wrote:

Hi

Am 18.01.24 um 09:32 schrieb Jiri Slaby:

quoted

On 18. 01. 24, 9:30, Thomas Zimmermann wrote:

quoted

Am 18.01.24 um 08:57 schrieb Jiri Slaby (SUSE):

quoted

There are VESA blanking constants defined in console.h already. So use
them in the console code instead of constant values.

These constants also exist in include/uapi/linux/fb.h. It would be
nice to find a common header where they can be shared.

Hi,

see 32/45.

I actually don't know how to fix that nicely while keeping uapi happy.

Is it hard to get a new UAPI header accepted (honest question)?

No.

There are a few things I'd like to split off from fbdev. But that
would require UAPI headers.

That's fine, create them, but you can't just delete an existing .h file
as that will usually break things.

thanks,

greg k-h