Thread (46 messages) 46 messages, 17 authors, 2024-01-10

Re: [PATCH 08/22] [v2] arch: consolidate arch_irq_work_raise prototypes

From: "Arnd Bergmann" <arnd@arndb.de>
Date: 2024-01-10 10:20:36
Also in: dri-devel, linux-alpha, linux-bcachefs, linux-kbuild, linux-m68k, linux-mips, linux-riscv, linux-s390, linux-sh, linux-trace-kernel, linux-usb, linuxppc-dev, lkml, loongarch, netdev, sparclinux

On Wed, Jan 10, 2024, at 10:03, Geert Uytterhoeven wrote:
On Wed, Nov 8, 2023 at 2:01 PM Arnd Bergmann [off-list ref] wrote:
quoted
From: Arnd Bergmann <arnd@arndb.de>

The prototype was hidden in an #ifdef on x86, which causes a warning:

kernel/irq_work.c:72:13: error: no previous prototype for 'arch_irq_work_raise' [-Werror=missing-prototypes]
This issue is now present upstream.
quoted
Some architectures have a working prototype, while others don't.
Fix this by providing it in only one place that is always visible.

Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Palmer Dabbelt <redacted>
Acked-by: Guo Ren <guoren@kernel.org>
Reviewed-by: Alexander Gordeev <agordeev@linux.ibm.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
I've sent out the asm-generic pull request now,
that contains the fix. Thanks for the reminder.

      Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help