Re: [PATCH 04/22] [RESEND] time: make sysfs_get_uname() function visible in header
From: Uwe Kleine-König <hidden>
Date: 2023-11-10 17:58:14
Also in:
dri-devel, linux-alpha, linux-bcachefs, linux-kbuild, linux-m68k, linux-mips, linux-riscv, linux-s390, linux-sh, linux-trace-kernel, linux-usb, linuxppc-dev, lkml, loongarch, netdev, sparclinux
Hello Arnd, On Wed, Nov 08, 2023 at 01:58:25PM +0100, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@arndb.de> This function is defined globally in clocksource.c and used conditionally in clockevent.c, which the declaration hidden when clockevent support
s/which/with/ ?
is disabled. This causes a harmless warning in the definition: kernel/time/clocksource.c:1324:9: warning: no previous prototype for 'sysfs_get_uname' [-Wmissing-prototypes] 1324 | ssize_t sysfs_get_uname(const char *buf, char *dst, size_t cnt) Move the declaration out of the #ifdef so it is always visible. Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Other than that: Reviewed-by: Uwe Kleine-König <redacted> -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachments
- signature.asc [application/pgp-signature] 488 bytes