RE: [PATCH v2 1/2] dt-bindings: backlight: Add MPS MP3309C

Hi Conor,

...

On Fri, Sep 15, 2023 at 04:05:15PM +0200, Flavio Suligoi wrote:

quoted

The Monolithic Power (MPS) MP3309C is a WLED step-up converter,
featuring a programmable switching frequency to optimize efficiency.
The brightness can be controlled either by I2C commands (called "analog"
mode) or by a PWM input signal (PWM mode).
This driver supports both modes.

For device driver details, please refer to:
- drivers/video/backlight/mp3309c_bl.c

The datasheet is available at:
- https://www.monolithicpower.com/en/mp3309c.html

Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
---

v2:
 - remove useless properties (dimming-mode, pinctrl-names, pinctrl-0,
   switch-on-delay-ms, switch-off-delay-ms, reset-gpios, reset-on-delay-ms,
   reset-on-length-ms)
 - add common.yaml#
 - remove already included properties (default-brightness,
max-brightness)
 - substitute three boolean properties, used for the overvoltage-protection
   values, with a single enum property
 - remove some conditional definitions
 - remove the 2nd example
v1:
 - first version

 .../bindings/leds/backlight/mps,mp3309c.yaml  | 73
+++++++++++++++++++
 1 file changed, 73 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml

diff --git
a/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
b/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
new file mode 100644
index 000000000000..99ccdba2c08f

--- /dev/null
+++

b/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yam

quoted

+++ l

@@ -0,0 +1,73 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/backlight/mps,mp3309c.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MPS MP3309C backlight
+
+maintainers:
+  - Flavio Suligoi <f.suligoi@asem.it>

...

quoted

+  mps,overvoltage-protection-microvolt:
+    description: Overvoltage protection (13.5V, 24V or 35.5V). If missing, the
+      hardware default of 35.5V is used.
+    enum: [ 13500000, 24000000, 35500000 ]

You can add "default: 35500000" and drop the free form default as text in the
description.

Ok, thanks.

Cheers,
Conor.

quoted

+
+  mps,no-sync-mode:
+    description: disable synchronous rectification mode
+    type: boolean
+
+required:
+  - compatible
+  - reg
+  - max-brightness
+  - default-brightness
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        /* Backlight with PWM control */
+        backlight_pwm: backlight@17 {
+            compatible = "mps,mp3309c-backlight";

As the bot pointed out, the compatible doesn't contain "backlight".

Right, fixed!

Thanks and regards,
Flavio