Re: [PATCH 00/47] fbdev: Use I/O helpers
From: Thomas Zimmermann <tzimmermann@suse.de>
Date: 2023-08-01 08:59:38
Also in:
dri-devel, kvm, linux-arm-kernel, linux-media, linux-omap
Hi Sam Am 28.07.23 um 20:39 schrieb Sam Ravnborg:
Hi Thomas, On Fri, Jul 28, 2023 at 06:39:43PM +0200, Thomas Zimmermann wrote:quoted
Most fbdev drivers operate on I/O memory. And most of those use the default implementations for file I/O and console drawing. Convert all these low-hanging fruits to the fb_ops initializer macro and Kconfig token for fbdev I/O helpers. The fbdev I/O helpers are easily grep-able. In a later patch, they can be left to empty values if the rsp. funtionality, such as file I/O or console, has been disabled.Did you miss sm750 or was it left out on purpose? As it hide in staging it is easy to miss.
Now I remembered why I left out sm750fb. It modifies the function pointers at some point at https://elixir.bootlin.com/linux/latest/source/drivers/staging/sm750fb/sm750.c#L741 So the driver uses a non-trivial fb_ops setup and is worth a different fix. Best regards Thomas
Sam
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Attachments
- OpenPGP_signature [application/pgp-signature] 840 bytes