Thread (58 messages) flat view 58 messages, 3 authors, 2023-08-01

Re: [PATCH 00/47] fbdev: Use I/O helpers

From: Sam Ravnborg <hidden>
Date: 2023-07-30 08:55:47
Also in: dri-devel, kvm, linux-arm-kernel, linux-media, linux-omap

On Fri, Jul 28, 2023 at 08:35:41PM +0200, Sam Ravnborg wrote:
Hi Thomas,

On Fri, Jul 28, 2023 at 06:39:43PM +0200, Thomas Zimmermann wrote:
quoted
Most fbdev drivers operate on I/O memory. And most of those use the
default implementations for file I/O and console drawing. Convert all
these low-hanging fruits to the fb_ops initializer macro and Kconfig
token for fbdev I/O helpers.

The fbdev I/O helpers are easily grep-able. In a later patch, they can
be left to empty values if the rsp. funtionality, such as file I/O or
console, has been disabled.

There are no functional changes. The helpers set the defaults that
the drivers already use.
I have browsed all patches - they all looks good.
Reviewed-by: Sam Ravnborg <redacted>
When you post v2 with MEM added the review still holds true.

	Sam
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help