Re: [PATCH v2 03/38] backlight/gpio_backlight: Compare against struct fb_info.device

From
Daniel Thompson <hidden>
Date
2023-06-13 10:38:54
Also in
dri-devel, linux-omap, linux-sh, linux-staging, lkml, stable
Reply to
Thomas Zimmermann, 2023-06-12
On Mon, Jun 12, 2023 at 04:07:41PM +0200, Thomas Zimmermann wrote:
Struct gpio_backlight_platform_data refers to a platform device within
the Linux device hierarchy. The test in gpio_backlight_check_fb()
compares it against the fbdev device in struct fb_info.dev, which
is different. Fix the test by comparing to struct fb_info.device.

Fixes a bug in the backlight driver and prepares fbdev for making
struct fb_info.dev optional.

v2:
	* move renames into separate patch (Javier, Sam, Michael)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 8b770e3c9824 ("backlight: Add GPIO-based backlight driver")
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Rich Felker <dalias@libc.org>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Lee Jones <lee@kernel.org>
Cc: Daniel Thompson <redacted>
Cc: Jingoo Han <jingoohan1@gmail.com>
Cc: <redacted>
Cc: <redacted>
Cc: <redacted> # v3.12+
Reviewed-by: Daniel Thompson <redacted>


Daniel.
Thread (56 messages) 56 messages, 6 authors, last reply 2023-06-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help