Re: [PATCH v2 01/38] backlight/bd6107: Compare against struct fb_info.device

From
Dan Carpenter <hidden>
Date
2023-06-12 15:01:01
Also in
dri-devel, linux-omap, linux-sh, linux-staging, lkml, stable
Reply to
Thomas Zimmermann, 2023-06-12
On Mon, Jun 12, 2023 at 04:07:39PM +0200, Thomas Zimmermann wrote:
Struct bd6107_platform_data refers to a platform device within
the Linux device hierarchy. The test in bd6107_backlight_check_fb()
compares it against the fbdev device in struct fb_info.dev, which
is different. Fix the test by comparing to struct fb_info.device.

Fixes a bug in the backlight driver and prepares fbdev for making
struct fb_info.dev optional.

v2:
	* move renames into separate patch (Javier, Sam, Michael)
Thanks.  This helps a lot.  I stared at this for a long time without
seeing the fix.  Then I misunderstood Sam's review comments (my fault,
they were clear in retrospect) so I got completely lost.

regards,
dan carpenter
Thread (56 messages) 56 messages, 6 authors, last reply 2023-06-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help