On Wed, May 17, 2023 at 9:59 PM Aaro Koskinen [off-list ref] wrote:

This does not compile as nokia770_ads7846_props is declared twice,
and nokia770_cbus_props and nokia770_mpuio_gpiochip_swnode are missing.

Hmmmm I think we should probably update omap1_defconfig to enable
all the OMAP1 drivers so we have good compile coverage. It's the
ifdefs that fool me into believeing the code actually compiles ...

On Mon, May 08, 2023 at 11:20:06PM +0200, Linus Walleij wrote:

quoted

+static const struct software_node_ref_args nokia770_cbus_gpio_refs[] = {
+     SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 9, 0),
+     SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 10, 0),
+     SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 11, 0),
+};

These should be nokia770_mpuio_gpiochip_node.

Fixed it.

quoted

+static const struct property_entry nokia770_ads7846_props[] = {
+     PROPERTY_ENTRY_REF_ARRAY("gpios", nokia770_cbus_gpio_refs),
+     { }
 };

This should be nokia770_cbus_props.

Fixed it.

Also enabled CONFIG_I2C_CBUS_GPIO and recompiled.

Yours,
Linus Walleij

Yours,
Linus Walleij