Thread (17 messages) 17 messages, 6 authors, 2023-06-14

Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes

From: Aaro Koskinen <aaro.koskinen@iki.fi>
Date: 2023-05-17 19:59:47
Also in: dri-devel, linux-arm-kernel, linux-input, linux-mips, linux-mmc, linux-omap, linux-spi, lkml

Hi,

This does not compile as nokia770_ads7846_props is declared twice,
and nokia770_cbus_props and nokia770_mpuio_gpiochip_swnode are missing.

On Mon, May 08, 2023 at 11:20:06PM +0200, Linus Walleij wrote:
+static const struct software_node_ref_args nokia770_cbus_gpio_refs[] = {
+	SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 9, 0),
+	SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 10, 0),
+	SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 11, 0),
+};
These should be nokia770_mpuio_gpiochip_node.
+static const struct property_entry nokia770_ads7846_props[] = {
+	PROPERTY_ENTRY_REF_ARRAY("gpios", nokia770_cbus_gpio_refs),
+	{ }
 };
This should be nokia770_cbus_props.

A.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help