Thread (12 messages) 12 messages, 3 authors, 2022-11-09

Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

From: Deepak R Varma <hidden>
Date: 2022-11-04 14:43:35
Also in: dri-devel, linux-staging, lkml

On Fri, Nov 04, 2022 at 05:31:24PM +0530, Deepak R Varma wrote:
On Mon, Oct 31, 2022 at 01:05:32PM +0100, Julia Lawall wrote:
quoted

I took a look, but it's pretty complex.  You could take the code and
reorganize it so that it is more readable, and then take the definition of
the ARRAY_SIZE macro, to better see what is going on.

julia
Hello Greg, Julia,
I was able to successfully build the fbtft object file for arm architecture as
well. I used gcc 6.5.0 and 9.5.0 tool chains. It was successful using both. I
have attached the build log from my machine for your reference.

I am also looking at the .i file and rearrange the expanded macro to understand
it. However, since it is built successfully, I am not sure if that is truly the
problem area.

Should I resend the patch and check if it still errors the kernel build bot?
Anything else I can try?
Looks like the change I proposed is causing nesting inside the write_reg
function due to additional set of { & } brackets for the __VA_ARGS__ symbol.

Am I understanding it right?
Thank you,
./drv

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help