Thread (12 messages) 12 messages, 3 authors, 2022-11-09

Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

flat view

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2022-10-29 07:32:02
Also in: dri-devel, linux-staging, lkml

On Fri, Oct 28, 2022 at 07:00:05PM +0530, Deepak R Varma wrote:
quoted hunk ↗ jump to hunk
The ARRAY_SIZE(foo) macro should be preferred over sizeof operator
based computation such as sizeof(foo)/sizeof(foo[0]) for finding
number of elements in an array. Issue identified using coccicheck.

Signed-off-by: Deepak R Varma <redacted>
---
 drivers/staging/fbtft/fbtft.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index 2c2b5f1c1df3..5506a473be91 100644
--- a/drivers/staging/fbtft/fbtft.h
+++ b/drivers/staging/fbtft/fbtft.h
@@ -231,7 +231,7 @@ struct fbtft_par {
 	bool polarity;
 };

-#define NUMARGS(...)  (sizeof((int[]){__VA_ARGS__}) / sizeof(int))
+#define NUMARGS(...)  ARRAY_SIZE(((int[]){ __VA_ARGS__ }))
Please please please test-build your patches before sending them out.
To not do so just wastes reviewer resources :(

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help