Re: [PATCH 00/21] ARM: s3c: clean out obsolete platforms

On Mon, Oct 24, 2022, at 15:00, Rob Herring wrote:

On Fri, Oct 21, 2022 at 10:22:28PM +0200, Arnd Bergmann wrote:

quoted

From: Arnd Bergmann <arnd@arndb.de>

The s3c24xx platform was marked as deprecated a while ago,
and for the s3c64xx platform, we marked all except one legacy
board file as unused.

This series removes all of those, leaving only s3c64xx support
for DT based boots as well as the cragg6410 board file.

About half of the s3c specific drivers were only used on
the now removed machines, so these drivers can be retired
as well. I can either merge the driver removal patches through
the soc tree along with the board file patches, or subsystem
maintainers can pick them up into their own trees, whichever
they prefer.

[...]

quoted

 Documentation/arm/index.rst                   |    1 -
 Documentation/arm/samsung-s3c24xx/cpufreq.rst |   77 -
 .../arm/samsung-s3c24xx/eb2410itx.rst         |   59 -
 Documentation/arm/samsung-s3c24xx/gpio.rst    |  172 --
 Documentation/arm/samsung-s3c24xx/h1940.rst   |   41 -
 Documentation/arm/samsung-s3c24xx/index.rst   |   20 -
 Documentation/arm/samsung-s3c24xx/nand.rst    |   30 -
 .../arm/samsung-s3c24xx/overview.rst          |  311 ---
 Documentation/arm/samsung-s3c24xx/s3c2412.rst |  121 -
 Documentation/arm/samsung-s3c24xx/s3c2413.rst |   22 -
 .../arm/samsung-s3c24xx/smdk2440.rst          |   57 -
 Documentation/arm/samsung-s3c24xx/suspend.rst |  137 --
 .../arm/samsung-s3c24xx/usb-host.rst          |   91 -
 Documentation/arm/samsung/overview.rst        |   13 -

What about?:

Documentation/devicetree/bindings/clock/samsung,s3c2410-clock.txt
Documentation/devicetree/bindings/interrupt-controller/samsung,s3c24xx-irq.txt
Documentation/devicetree/bindings/mmc/samsung,s3cmci.txt

Good catch!

I've removed these three now and and will add the removal to
the same patch, also the related
samsung,s3c2412-clock.txt and samsung,s3c2443-clock.txt
files.

Documentation/devicetree/bindings/mtd/samsung-s3c2410.txt

samsung,s3c2412-nand is apparently still used on s3c6400,
and the driver is selectable on that platform, so I think
that should remain in there until we remove s3c64xx in 2024,
even if it is not referenced by the dts files in the kernel.

Documentation/devicetree/bindings/usb/s3c2410-usb.txt

Similarly, the driver is used on the crag6410 board
(without DT), and probably just works with the DT based
boards if one adds a node to s3c64xx.dtsi.

I've also checked if any of the other removed drivers
matches of_device_id[] strings to see if there are more
bindings to kill off, but I don't see any that have
now become obsolete. It did point me to pxa2xx_ac97_dt_ids,
which Robert already complained about, this apparently
is still used with dts files outside of mainline.

      Arnd