Thread (50 messages) 50 messages, 8 authors, 2022-09-22

Re: [PATCH v2 10/10] drm/ofdrm: Support color management

From: Thomas Zimmermann <tzimmermann@suse.de>
Date: 2022-09-22 06:42:32
Also in: dri-devel, linuxppc-dev

Hi

Am 21.09.22 um 18:48 schrieb Geert Uytterhoeven:
Hi Thomas,

On Wed, Sep 21, 2022 at 2:55 PM Thomas Zimmermann [off-list ref] wrote:
quoted
Am 05.08.22 um 02:19 schrieb Benjamin Herrenschmidt:
quoted
On Wed, 2022-07-20 at 16:27 +0200, Thomas Zimmermann wrote:
quoted
+#if !defined(CONFIG_PPC)
+static inline void out_8(void __iomem *addr, int val)
+{ }
+static inline void out_le32(void __iomem *addr, int val)
+{ }
+static inline unsigned int in_le32(const void __iomem *addr)
+{
+       return 0;
+}
+#endif
These guys could just be replaced with readb/writel/readl respectively
(beware of the argument swap).
I only added them for COMPILE_TEST. There appears to be no portable
interface that implements out_le32() and in_le32()?
iowrite32() and ioread32()?
Do they always use little endian, as these *_le32 helpers do? I though 
they use host byte order.

Best regards
Thomas
Gr{oetje,eeting}s,

                         Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                 -- Linus Torvalds
-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help