Re: [PATCH v2 09/10] drm/ofdrm: Add per-model device function
From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2022-07-26 13:38:48
Also in:
dri-devel, linuxppc-dev
On 7/20/22 16:27, Thomas Zimmermann wrote:
Add a per-model device-function structure in preparation of adding color-management support. Detection of the individual models has been taken from fbdev's offb. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> ---
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> [...]
quoted hunk ↗ jump to hunk
+static bool is_avivo(__be32 vendor, __be32 device) +{ + /* This will match most R5xx */ + return (vendor == 0x1002) && + ((device >= 0x7100 && device < 0x7800) || (device >= 0x9400)); +}
Maybe add some constant macros to not have these magic numbers ? -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat