Re: [PATCH] tty: vt: selection: Add check for valid tiocl_selection values

From
Adam Borowski <hidden>
Date
2022-08-05 11:13:53
Also in
dri-devel, lkml
Reply to
Jiri Slaby, 2022-08-04
On Thu, Aug 04, 2022 at 11:22:26AM +0200, Jiri Slaby wrote:
On 04. 08. 22, 10:44, Helge Deller wrote:
quoted
On 8/4/22 09:15, Helge Deller wrote:
quoted
On 8/4/22 07:47, Jiri Slaby wrote:
quoted
On 30. 07. 22, 20:49, Helge Deller wrote:
quoted
The line and column numbers for the selection need to start at 1.
Add the checks to prevent invalid input.
quoted
quoted
quoted
quoted
--- a/drivers/tty/vt/selection.c
+++ b/drivers/tty/vt/selection.c
@@ -326,6 +326,9 @@ static int vc_selection(struct vc_data *vc, struct tiocl_selection *v,
+    if (!v->xs || !v->ys || !v->xe || !v->ye)
+        return -EINVAL;
Hmm, I'm not sure about this. It potentially breaks userspace (by
returning EINVAL now).
We can still do a trial and revert it if something breaks... It's just that
_noone_ knows with all this undocumented stuff ;).

But in fact, 0 currently means full row/column. Isn't it on purpose?

Today, we are out of luck, codesearch.debian.net gives no clue about users:
https://codesearch.debian.net/search?q=%5CbTIOCL_SETSEL%5Cb&literal=0
That's because the macro is undocumented.

"man ioctl_console" says:
       TIOCLINUX, subcode=2
              Set selection.  argp points to a [...]

thus everyone writes it as a number.

You'd need to grep for TIOCLINUX; there's not that many references to
check...


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Say what you want about Adolf, at least he was the man who
⢿⡄⠘⠷⠚⠋⠀ killed Hitler.  Your turn, Vlad!
⠈⠳⣄⠀⠀⠀⠀
Thread (19 messages) 19 messages, 5 authors, last reply 2022-08-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help