Re: [PATCH] tty: vt: selection: Add check for valid tiocl_selection values

From
Jiri Slaby <jirislaby@kernel.org>
Date
2022-08-04 05:47:40
Also in
dri-devel, lkml
Reply to
Helge Deller, 2022-07-30
On 30. 07. 22, 20:49, Helge Deller wrote:
quoted hunk ↗ jump to hunk
The line and column numbers for the selection need to start at 1.
Add the checks to prevent invalid input.

Signed-off-by: Helge Deller <deller@gmx.de>
Reported-by: <redacted>
diff --git a/drivers/tty/vt/selection.c b/drivers/tty/vt/selection.c
index f7755e73696e..58692a9b4097 100644
--- a/drivers/tty/vt/selection.c
+++ b/drivers/tty/vt/selection.c
@@ -326,6 +326,9 @@ static int vc_selection(struct vc_data *vc, struct tiocl_selection *v,
  		return 0;
  	}

+	if (!v->xs || !v->ys || !v->xe || !v->ye)
+		return -EINVAL;
Hmm, I'm not sure about this. It potentially breaks userspace (by returning EINVAL now). And the code below should handle this just fine, right:
quoted hunk ↗ jump to hunk
+
  	v->xs = min_t(u16, v->xs - 1, vc->vc_cols - 1);
  	v->ys = min_t(u16, v->ys - 1, vc->vc_rows - 1);
  	v->xe = min_t(u16, v->xe - 1, vc->vc_cols - 1);
?

thanks,
-- 
js
suse labs
Thread (19 messages) 19 messages, 5 authors, last reply 2022-08-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help