Re: [PATCH 10/11] fbdev: Acquire framebuffer apertures for firmware devices
From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2022-07-11 11:29:17
Also in:
dri-devel, linux-staging
From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2022-07-11 11:29:17
Also in:
dri-devel, linux-staging
On 7/7/22 17:39, Thomas Zimmermann wrote:
When registering a generic framebuffer, automatically acquire ownership of the framebuffer's I/O range. The device will now be handled by the aperture helpers. Fbdev-based conflict handling is no longer required. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/video/fbdev/core/fbmem.c | 33 ++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index 2237049327db..e556ad69f48f 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c@@ -13,6 +13,7 @@ #include <linux/module.h> +#include <linux/aperture.h> #include <linux/compat.h> #include <linux/types.h> #include <linux/errno.h>@@ -1739,6 +1740,32 @@ static void do_unregister_framebuffer(struct fb_info *fb_info) put_fb_info(fb_info); } +static int fbm_aperture_acquire_for_platform_device(struct fb_info *fb_info) +{
What's the meaning of 'm' here ? Misc, memory ? I would just call it 'fb_'. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat