Thread (31 messages) 31 messages, 2 authors, 2022-07-15

Re: [PATCH 08/11] video: Provide constants for VGA I/O range

From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2022-07-11 11:21:47
Also in: dri-devel, linux-staging

On 7/7/22 17:39, Thomas Zimmermann wrote:
Provide VGA_FB_ constants for the VGA framebuffer I/O range and convert
fbdev code.
I would probably mention in the commit message to that you are renaming
s/VGA_FB_PHYS/VGA_FB_PHYS_BASE and s/VGA_FB_PHYS_LEN/VGA_FB_PHYS_SIZE.

I do agree with the rename and think that makes it much more readable,
but think that's worth to mention the rationale for that change too.
 
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help