Thread (38 messages) 38 messages, 8 authors, 2022-07-21

Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

From: Andy Shevchenko <hidden>
Date: 2022-07-15 13:06:25
Also in: dri-devel, linux-arm-kernel, linux-devicetree, linux-iio, linux-leds, linux-mediatek, linux-pm, linux-usb, lkml 

On Fri, Jul 15, 2022 at 2:40 PM AngeloGioacchino Del Regno
[off-list ref] wrote:
Il 15/07/22 13:26, ChiaEn Wu ha scritto:
...
quoted
+#define STATE_OFF                            0
+#define STATE_KEEP                           1
+#define STATE_ON                             2
I propose, instead:

enum mt6370_state {
        STATE_OFF = 0,
        STATE_KEEP,
        STATE_ON,
        STATE_MAX,
Usually we don't put commas at the terminator entries.

};
-- 
With Best Regards,
Andy Shevchenko
  



    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help