Re: [PATCH AUTOSEL 4.9 08/13] video: fbdev: simplefb: Check before clk_put() not needed
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2022-06-30 19:31:30
Also in:
dri-devel, lkml, stable
Possibly related (same subject, not in this thread)
- 2022-09-14 · [PATCH AUTOSEL 4.9 08/13] video: fbdev: simplefb: Check before clk_put() not needed · Sasha Levin <sashal@kernel.org>
Hi Sasha, On Tue, Jun 28, 2022 at 4:32 AM Sasha Levin [off-list ref] wrote:
From: Yihao Han <redacted> [ Upstream commit 5491424d17bdeb7b7852a59367858251783f8398 ] clk_put() already checks the clk ptr using !clk and IS_ERR()
While I think that is true for all clock implementations in v5.19-rc4, it is not true for v4.9.320.
so there is no need to check it again before calling it. Signed-off-by: Yihao Han <redacted> Reviewed-by: Hans de Goede <redacted> Signed-off-by: Helge Deller <deller@gmx.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
quoted hunk ↗ jump to hunk
--- a/drivers/video/fbdev/simplefb.c +++ b/drivers/video/fbdev/simplefb.c@@ -231,8 +231,7 @@ static int simplefb_clocks_init(struct simplefb_par *par, if (IS_ERR(clock)) { if (PTR_ERR(clock) == -EPROBE_DEFER) { while (--i >= 0) { - if (par->clks[i]) - clk_put(par->clks[i]); + clk_put(par->clks[i]); } kfree(par->clks); return -EPROBE_DEFER;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds