Thread (3 messages) 3 messages, 3 authors, 2022-06-30
STALE1552d REVIEWED: 1 (0M)

1 review trailer.

[PATCH AUTOSEL 4.9 08/13] video: fbdev: simplefb: Check before clk_put() not needed

From: Sasha Levin <sashal@kernel.org>
Date: 2022-06-28 02:34:23
Also in: dri-devel, lkml, stable
Subsystem: framebuffer layer, simplefb fb driver, the rest · Maintainers: Helge Deller, Hans de Goede, Linus Torvalds

Possibly related (same subject, not in this thread)

From: Yihao Han <redacted>

[ Upstream commit 5491424d17bdeb7b7852a59367858251783f8398 ]

clk_put() already checks the clk ptr using !clk and IS_ERR()
so there is no need to check it again before calling it.

Signed-off-by: Yihao Han <redacted>
Reviewed-by: Hans de Goede <redacted>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/video/fbdev/simplefb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
index 61f799a515dc..1efdbbc20f99 100644
--- a/drivers/video/fbdev/simplefb.c
+++ b/drivers/video/fbdev/simplefb.c
@@ -231,8 +231,7 @@ static int simplefb_clocks_init(struct simplefb_par *par,
 		if (IS_ERR(clock)) {
 			if (PTR_ERR(clock) == -EPROBE_DEFER) {
 				while (--i >= 0) {
-					if (par->clks[i])
-						clk_put(par->clks[i]);
+					clk_put(par->clks[i]);
 				}
 				kfree(par->clks);
 				return -EPROBE_DEFER;
-- 
2.35.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help