Re: [PATCH v12 05/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver
From: CK Hu <hidden>
Date: 2022-06-28 05:23:31
Also in:
dri-devel, linux-arm-kernel, linux-devicetree, linux-mediatek, lkml
Hi, Bo-Chen: On Mon, 2022-06-27 at 16:03 +0800, Bo-Chen Chen wrote:
quoted hunk ↗ jump to hunk
From: Markus Schneider-Pargmann <msp@baylibre.com> This patch adds a embedded displayport driver for the MediaTek mt8195 SoC. It supports the MT8195, the embedded DisplayPort units. It offers DisplayPort 1.4 with up to 4 lanes. The driver creates a child device for the phy. The child device will never exist without the parent being active. As they are sharing a register range, the parent passes a regmap pointer to the child so that both can work with the same register range. The phy driver sets device data that is read by the parent to get the phy device that can be used to control the phy properties. This driver is based on an initial version by Jitao shi [off-list ref] Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> Signed-off-by: Guillaume Ranquet <redacted> [Bo-Chen: Cleanup the drivers and modify comments from reviewers] Signed-off-by: Bo-Chen Chen <redacted> --- drivers/gpu/drm/mediatek/Kconfig | 10 + drivers/gpu/drm/mediatek/Makefile | 1 + drivers/gpu/drm/mediatek/mtk_dp.c | 2198 ++++++++++++++++++++++++ drivers/gpu/drm/mediatek/mtk_dp_reg.h | 543 ++++++ drivers/gpu/drm/mediatek/mtk_drm_drv.c | 3 + drivers/gpu/drm/mediatek/mtk_drm_drv.h | 3 + 6 files changed, 2758 insertions(+) create mode 100644 drivers/gpu/drm/mediatek/mtk_dp.c create mode 100644 drivers/gpu/drm/mediatek/mtk_dp_reg.hdiff --git a/drivers/gpu/drm/mediatek/Kconfigb/drivers/gpu/drm/mediatek/Kconfig index 2976d21e9a34..6d3af73e7e8c 100644--- a/drivers/gpu/drm/mediatek/Kconfig +++ b/drivers/gpu/drm/mediatek/Kconfig@@ -15,12 +15,22 @@ config DRM_MEDIATEK select MTK_SMI select PHY_MTK_MIPI_DSI select VIDEOMODE_HELPERS + select DRM_MEDIATEK_DP
Remove this.
help Choose this option if you have a Mediatek SoCs. The module will be called mediatek-drm This driver provides kernel mode setting and buffer management to userspace. +config DRM_MEDIATEK_DP + tristate "DRM DPTX Support for MediaTek SoCs" + depends on DRM_MEDIATEK + select PHY_MTK_DP + select DRM_DISPLAY_HELPER + select DRM_DISPLAY_DP_HELPER + help + DRM/KMS Display Port driver for MediaTek SoCs. +
[snip]
quoted hunk ↗ jump to hunk
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.cb/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 78e79c8449c8..8023f1bd5f7e 100644--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c@@ -1033,6 +1033,9 @@ static struct platform_driver * constmtk_drm_drivers[] = { &mtk_disp_ovl_driver, &mtk_disp_rdma_driver, &mtk_dpi_driver, +#if IS_REACHABLE(CONFIG_DRM_MEDIATEK_DP) + &mtk_dp_driver, +#endif
Remove this, and treat dp driver like hdmi driver. Regards, CK
&mtk_drm_platform_driver, &mtk_dsi_driver, &mtk_ethdr_driver,