Re: [PATCH v11 05/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver

Hi, Bo-Chen:

On Fri, 2022-06-10 at 18:55 +0800, Bo-Chen Chen wrote:

From: Markus Schneider-Pargmann <msp@baylibre.com>

This patch adds a embedded displayport driver for the MediaTek mt8195
SoC.

It supports the MT8195, the embedded DisplayPort units. It offers
DisplayPort 1.4 with up to 4 lanes.

The driver creates a child device for the phy. The child device will
never exist without the parent being active. As they are sharing a
register range, the parent passes a regmap pointer to the child so
that
both can work with the same register range. The phy driver sets
device
data that is read by the parent to get the phy device that can be
used
to control the phy properties.

This driver is based on an initial version by
Jitao shi [off-list ref]

Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
Signed-off-by: Guillaume Ranquet <redacted>
[Bo-Chen: Cleanup the drivers and modify comments from reviewers]
Signed-off-by: Bo-Chen Chen <redacted>
---

[snip]

+
+#define MTK_DP_ENC0_P0_3130			(ENC0_OFFSET + 0x130)

This is useless in this patch, so remove it.
If this is used in later patch, add this back in that patch.

+#define MTK_DP_ENC0_P0_3138			(ENC0_OFFSET + 0x138)

Ditto.

Regards,
CK