On Thu, May 26, 2022 at 12:32:12PM +0200, Krzysztof Kozlowski wrote:

On 26/05/2022 10:13, ChiYuan Huang wrote:

quoted

Krzysztof Kozlowski [off-list ref] 於 2022年5月26日 週四 下午4:06寫道：

quoted

On 26/05/2022 05:16, cy_huang wrote:

quoted

From: ChiYuan Huang <redacted>

Add the new property for ocp level selection.

Signed-off-by: ChiYuan Huang <redacted>
---
 .../bindings/leds/backlight/richtek,rt4831-backlight.yaml         | 8 ++++++++
 include/dt-bindings/leds/rt4831-backlight.h                       | 5 +++++
 2 files changed, 13 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
index e0ac686..c1c59de 100644
--- a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
+++ b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml

@@ -47,6 +47,14 @@ properties:
     minimum: 0
     maximum: 3

+  richtek,bled-ocp-sel:

Skip "sel" as it is a shortcut of selection. Name instead:
"richtek,backlight-ocp"

OK, if so, do I need to rename all properties from 'bled' to 'backlight' ?
If  only this property is naming as 'backlight'. it may conflict with
the others like as "richtek,bled-ovp-sel".

Ah, no, no need.

quoted

quoted

quoted

+    description: |
+      Backlight OCP level selection, currently support 0.9A/1.2A/1.5A/1.8A

Could you explain here what is OCP (unfold the acronym)?

Yes. And the full name is 'over current protection'.

Thanks and this leads to second thing - you encode register value
instead of logical value. This must be a logical value in mA, so
"richtek,bled-ocp-microamp".

We already have common properties for setting current of LEDs. We should 
use that here I think.

Rob