Re: [PATCH v2 RFC 07/10] drm/gem-fb-helper: Use actual bpp for size calculations

[PATCH v2 00/10] drm: Add support for low-color frame buffer formats · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-07
[PATCH v2 03/10] drm/client: Use actual bpp when allocating frame buffers · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-07
Re: [PATCH v2 03/10] drm/client: Use actual bpp when allocating frame buffers · Javier Martinez Canillas <javierm@redhat.com> · 2022-03-09
[PATCH v2 RFC 07/10] drm/gem-fb-helper: Use actual bpp for size calculations · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-07
Re: [PATCH v2 RFC 07/10] drm/gem-fb-helper: Use actual bpp for size calculations · Javier Martinez Canillas <javierm@redhat.com> · 2022-03-09
[PATCH v2 06/10] drm/fb-helper: Add support for DRM_FORMAT_C[124] · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-07
Re: [PATCH v2 06/10] drm/fb-helper: Add support for DRM_FORMAT_C[124] · Javier Martinez Canillas <javierm@redhat.com> · 2022-03-09
Re: [PATCH v2 06/10] drm/fb-helper: Add support for DRM_FORMAT_C[124] · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-09
[PATCH v2 RFC 09/10] drm/fourcc: Add DRM_FORMAT_R[124] · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-07
Re: [PATCH v2 RFC 09/10] drm/fourcc: Add DRM_FORMAT_R[124] · Javier Martinez Canillas <javierm@redhat.com> · 2022-03-09
[PATCH v2 RFC 08/10] drm/fourcc: Document that single-channel "red" can be any color · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-07
Re: [PATCH v2 RFC 08/10] drm/fourcc: Document that single-channel "red" can be any color · Pekka Paalanen <ppaalanen@gmail.com> · 2022-03-08
Re: [PATCH v2 RFC 08/10] drm/fourcc: Document that single-channel "red" can be any color · Javier Martinez Canillas <javierm@redhat.com> · 2022-03-09
[PATCH v2 02/10] drm/fourcc: Add drm_format_info.is_color_indexed flag · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-07
Re: [PATCH v2 02/10] drm/fourcc: Add drm_format_info.is_color_indexed flag · Javier Martinez Canillas <javierm@redhat.com> · 2022-03-09
[PATCH v2 RFC 10/10] drm/fourcc: Add DRM_FORMAT_D[1248] · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-07
Re: [PATCH v2 RFC 10/10] drm/fourcc: Add DRM_FORMAT_D[1248] · Javier Martinez Canillas <javierm@redhat.com> · 2022-03-09
[PATCH v2 01/10] drm/fourcc: Add drm_format_info_bpp() helper · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-07
Re: [PATCH v2 01/10] drm/fourcc: Add drm_format_info_bpp() helper · Javier Martinez Canillas <javierm@redhat.com> · 2022-03-09
[PATCH v2 05/10] drm/fourcc: Add DRM_FORMAT_C[124] · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-07
Re: [PATCH v2 05/10] drm/fourcc: Add DRM_FORMAT_C[124] · Pekka Paalanen <ppaalanen@gmail.com> · 2022-03-08
Re: [PATCH v2 05/10] drm/fourcc: Add DRM_FORMAT_C[124] · Javier Martinez Canillas <javierm@redhat.com> · 2022-03-09
Re: [PATCH v2 05/10] drm/fourcc: Add DRM_FORMAT_C[124] · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-14
Re: [PATCH v2 05/10] drm/fourcc: Add DRM_FORMAT_C[124] · Pekka Paalanen <ppaalanen@gmail.com> · 2022-03-14
Re: [PATCH v2 05/10] drm/fourcc: Add DRM_FORMAT_C[124] · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-14
Re: [PATCH v2 05/10] drm/fourcc: Add DRM_FORMAT_C[124] · Finn Thain <fthain@linux-m68k.org> · 2022-03-14
Re: [PATCH v2 05/10] drm/fourcc: Add DRM_FORMAT_C[124] · Pekka Paalanen <ppaalanen@gmail.com> · 2022-03-15
Re: [PATCH v2 05/10] drm/fourcc: Add DRM_FORMAT_C[124] · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-15
Re: [PATCH v2 05/10] drm/fourcc: Add DRM_FORMAT_C[124] · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-15
Re: [PATCH v2 05/10] drm/fourcc: Add DRM_FORMAT_C[124] · Pekka Paalanen <ppaalanen@gmail.com> · 2022-03-15
Re: [PATCH v2 05/10] drm/fourcc: Add DRM_FORMAT_C[124] · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-15
Re: [PATCH v2 05/10] drm/fourcc: Add DRM_FORMAT_C[124] · Pekka Paalanen <ppaalanen@gmail.com> · 2022-03-15
[PATCH v2 04/10] drm/framebuffer: Use actual bpp for DRM_IOCTL_MODE_GETFB · Geert Uytterhoeven <geert@linux-m68k.org> · 2022-03-07
Re: [PATCH v2 04/10] drm/framebuffer: Use actual bpp for DRM_IOCTL_MODE_GETFB · Javier Martinez Canillas <javierm@redhat.com> · 2022-03-09

From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2022-03-09 13:16:30
Also in: dri-devel, linux-m68k, lkml

On 3/7/22 21:52, Geert Uytterhoeven wrote:

The AFBC helpers derive the number of bits per pixel from the deprecated
drm_format_info.cpp[] field, which does not take into account block
sizes.

Fix this by using the actual number of bits per pixel instead.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
RFC, as this code path was untested.

Looks good to me but haven't tested either.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help