Quoting Chun-Kuang Hu (2022-02-21 03:32:32)

Hi, Guillaume:

Guillaume Ranquet [off-list ref] 於 2022年2月18日 週五 下午10:56寫道：

quoted

Adds a bit of flexibility to support boards without swap_input support

Signed-off-by: Guillaume Ranquet <redacted>
---
 drivers/gpu/drm/mediatek/mtk_dpi.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 545a1337cc899..454f8563efae4 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c

@@ -126,6 +126,7 @@ struct mtk_dpi_conf {
        const u32 *output_fmts;
        u32 num_output_fmts;
        bool is_ck_de_pol;
+       bool swap_input_support;
        const struct mtk_dpi_yc_limit *limit;
 };

@@ -378,18 +379,21 @@ static void mtk_dpi_config_color_format(struct mtk_dpi *dpi,
            (format == MTK_DPI_COLOR_FORMAT_YCBCR_444_FULL)) {
                mtk_dpi_config_yuv422_enable(dpi, false);
                mtk_dpi_config_csc_enable(dpi, true);
-               mtk_dpi_config_swap_input(dpi, false);
+               if (dpi->conf->swap_input_support)
+                       mtk_dpi_config_swap_input(dpi, false);
                mtk_dpi_config_channel_swap(dpi, MTK_DPI_OUT_CHANNEL_SWAP_BGR);
        } else if ((format == MTK_DPI_COLOR_FORMAT_YCBCR_422) ||
                   (format == MTK_DPI_COLOR_FORMAT_YCBCR_422_FULL)) {
                mtk_dpi_config_yuv422_enable(dpi, true);
                mtk_dpi_config_csc_enable(dpi, true);
-               mtk_dpi_config_swap_input(dpi, true);
+               if (dpi->conf->swap_input_support)
+                       mtk_dpi_config_swap_input(dpi, true);

In MT8173, MT2701, MT8183, MT8192, YCBCR_444 would not swap but
YCBCR_422 would swap. But In MT8195, both YCBCR_444 and YCBCR_422
would not swap, So I think one of these format would be abnormal in
MT8195, right? Or would you provide more information about how this
swap work?

Regards,
Chun-Kuang.

I'm not sure I have access to that level of information... and my
knowledge on mediatek
SoC is rather limited, I will circle back with mediatek engineers to
have a definite
answer.

Thx,
Guillaume

quoted

                mtk_dpi_config_channel_swap(dpi, MTK_DPI_OUT_CHANNEL_SWAP_RGB);
        } else {
                mtk_dpi_config_yuv422_enable(dpi, false);
                mtk_dpi_config_csc_enable(dpi, false);
-               mtk_dpi_config_swap_input(dpi, false);
+               if (dpi->conf->swap_input_support)
+                       mtk_dpi_config_swap_input(dpi, false);
                mtk_dpi_config_channel_swap(dpi, MTK_DPI_OUT_CHANNEL_SWAP_RGB);
        }
 }

@@ -808,6 +812,7 @@ static const struct mtk_dpi_conf mt8173_conf = {
        .output_fmts = mt8173_output_fmts,
        .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
        .is_ck_de_pol = true,
+       .swap_input_support = true,
        .limit = &mtk_dpi_limit,
 };

@@ -819,6 +824,7 @@ static const struct mtk_dpi_conf mt2701_conf = {
        .output_fmts = mt8173_output_fmts,
        .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
        .is_ck_de_pol = true,
+       .swap_input_support = true,
        .limit = &mtk_dpi_limit,
 };

@@ -829,6 +835,7 @@ static const struct mtk_dpi_conf mt8183_conf = {
        .output_fmts = mt8183_output_fmts,
        .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
        .is_ck_de_pol = true,
+       .swap_input_support = true,
        .limit = &mtk_dpi_limit,
 };

@@ -839,6 +846,7 @@ static const struct mtk_dpi_conf mt8192_conf = {
        .output_fmts = mt8173_output_fmts,
        .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
        .is_ck_de_pol = true,
+       .swap_input_support = true,
        .limit = &mtk_dpi_limit,
 };

--

2.34.1