Re: [PATCH v8 09/19] drm/mediatek: dpi: move dimension_mask to board config
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Date: 2022-02-21 14:31:44
Also in:
dri-devel, linux-arm-kernel, linux-devicetree, linux-mediatek, linux-phy, lkml
Il 18/02/22 15:54, Guillaume Ranquet ha scritto:
Add flexibility by moving the dimension mask to board config
You should really fix both title and description for this commit, as this is moving hvsize_mask, not dimension_mask. Also, s/board/SoC/g.
quoted hunk ↗ jump to hunk
Signed-off-by: Guillaume Ranquet <redacted> --- drivers/gpu/drm/mediatek/mtk_dpi.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index 8ca3455ed64ee..0d3acd08ea358 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c@@ -129,6 +129,8 @@ struct mtk_dpi_conf { bool swap_input_support; // Mask used for HWIDTH, HPORCH, VSYNC_WIDTH and VSYNC_PORCH (no shift) u32 dimension_mask; + // Mask used for HSIZE and VSIZE (no shift)
C-style comments please
+ u32 hvsize_mask; const struct mtk_dpi_yc_limit *limit; };