Re: [PATCH v1 1/4] fbtft: Unorphan the driver

On 1/26/22 15:10, Andy Shevchenko wrote:

On Wed, Jan 26, 2022 at 04:08:32PM +0200, Andy Shevchenko wrote:

quoted

On Wed, Jan 26, 2022 at 02:46:08PM +0100, Javier Martinez Canillas wrote:

quoted

On 1/26/22 14:12, Andy Shevchenko wrote:

...

quoted

quoted

I've just bought a SSD1306 (I2C) based one and will attempt to write a DRM
driver using drivers/staging/fbtft/fb_ssd1306.c as a reference.

You should take ssd1307fb.c instead. And basically create a MIPI based driver
for I2C. Then we won't go same road again for other similar devices.

For the record it supports your device:

static const struct i2c_device_id ssd1307fb_i2c_id[] = {
{ "ssd1305fb", 0 },
{ "ssd1306fb", 0 },
{ "ssd1307fb", 0 },
{ "ssd1309fb", 0 },

Thanks a lot for the pointer. I was only looking at drivers/staging
and didn't check drivers/video. I'll try to convert that one then
once I get the display.

Best regards,
-- 
Javier Martinez Canillas
Linux Engineering
Red Hat